Refactoring: moved all code for appying profile to ODataDefaultProfileUtils class #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a profile resource.
the ODataDefaultProfileUtils class.
|
Thank you for your contribution. I'll review your pull request as soon as I can. Hamza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code so that you only have to provide a model resource and a profile resource to the ODataDefaultProfileUtils.applyODataProfile method to apply the OData profile on a model.
I did this because I would like to be able to use the ODataDefaultProfileUtils independent from Papyrus/Eclipse in a stand-alone application.
Because I'm not familiar with building Eclipse plug-ins, I did not test these changes. Nor did I manage to rebuild the jars to update som.odata.update. So, testing is still required.